New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line filters: Validation #989

Open

1 task

gtk-grafana opened this issue Jan 9, 2025 · 0 comments

Labels

epic

Milestone

Contributor

gtk-grafana commented Jan 9, 2025 •

edited

Loading

In #963, we introduced regex in line-filters.
Can we validate the users input better?

See: #963 (comment)

Frontend validation:
Regex validation:

Using JS RegExp would be easy, but not technically valid.
RE2 parsers for JS exist, but they are heavy
- https://www.npmjs.com/package/re2js is 3.22MB
  Non regex: Can we check for invalid chars that will break queries?
Backticks are always invalid

Backend validation:
Can we run an instant query or something fast to use Loki to validate?

Line filters: Allow backticks #992

Needs some investigation.

gtk-grafana added the epic label

gtk-grafana added this to the 1.0.6 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment