Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some functions in sll has no namespace but too generic names #35

Open
EmilyBourne opened this issue Dec 19, 2024 · 0 comments
Open

Some functions in sll has no namespace but too generic names #35

EmilyBourne opened this issue Dec 19, 2024 · 0 comments

Comments

@EmilyBourne
Copy link
Member

Ie., the function save_logger() here:

https://gitlab.maisondelasimulation.fr/gysela-developpers/gyselalibxx/-/blob/main/vendor/sll/include/sll/matrix_utils.hpp?ref_type=heads#L89

Has no namespace and is thus exposed to all classes using the MatrixBatchEll/Csr classes (ie. Poisson-related classes). The name being generic, it would be in conflict with any function sharing the same name.

Several solutions:

  • Use more specialized names (like matrix_batch_save_logger...)
  • Add a namespace to Matrix classes (just MatrixBatchEll/Csr, other SLL matrices being planned to be removed, see #293 )\n\n__Issue originally opened by @blegouix on GitLab__
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant