Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-integrate the activation delay for uniswap oracle #31

Open
thomas-waite opened this issue May 31, 2020 · 0 comments
Open

Re-integrate the activation delay for uniswap oracle #31

thomas-waite opened this issue May 31, 2020 · 0 comments
Assignees

Comments

@thomas-waite
Copy link
Contributor

thomas-waite commented May 31, 2020

Summary

The Uniswap Oracle has an activation delay of 24hrs hardcoded into it. This was removed for the purposes of the hackathon submission - didn't have time to wait 24hrs for it to activate!

TODOs

  1. Put the activation delay back in and a deployment pipeline setup which anticipates and accounts for this when pushing updates.

  2. Update test fixture to fast forward 24hrs by default - the tests are written as if the 24hr delay is on the contract. However this could also be cleaned up, as we call a specific context contextForOracleActivated() for each unit test that relies on the oracle activating - it should be the default, rather than the specific exception.

  3. Find an automated way of calling await oracle.update() every 24hrs

@thomas-waite thomas-waite mentioned this issue May 31, 2020
@thomas-waite thomas-waite self-assigned this May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant