Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit correct Transfer and Approval events for ERC721 #194

Open
acuarica opened this issue Jan 14, 2025 · 0 comments
Open

Emit correct Transfer and Approval events for ERC721 #194

acuarica opened this issue Jan 14, 2025 · 0 comments

Comments

@acuarica
Copy link
Contributor

The events declared for ERC721 in IERC721Events do not contain the Transfer and Approval methods. This is because the ERC721 implementation reuses the events from ERC20.

However, there is a slight difference. The uint256 argument is indexed for ERC721, but not for ERC20. This can lead to inconsistencies.

Use and emit the proper event definitions for the ERC721 implementation.
@acuarica acuarica added bug A error that causes the feature to behave differently than what was expected based on design docs and removed bug A error that causes the feature to behave differently than what was expected based on design docs labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Smart Contract Sprint Board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acuarica