chore: add warning log for invalid node account #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Ivanov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2171 +/- ##
============================================
+ Coverage 82.20% 82.41% +0.21%
- Complexity 3588 4042 +454
============================================
Files 186 205 +19
Lines 11697 12913 +1216
Branches 1150 1283 +133
============================================
+ Hits 9615 10642 +1027
- Misses 1604 1813 +209
+ Partials 478 458 -20 ☔ View full report in Codecov by Sentry. |
naydenovn
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Recently there were increased complaints for
INVALID_NODE_ACCOUNTerror. After debugging with the team it turns out if a transaction is built to be a submitted to a specific node, but that node is not listed in the Clinet's list instead of throwing an error the SDK will send the transaction to a random node and it will reach the consensus node where it will fail at PRECHECK.This PR adds log that warns the user that the client configuration is incorrect and it might cause
INVALID_NODE_ACCOUNTRelated issue(s):
Fixes #2124
Notes for reviewer:
Checklist