Background

(See hashgraph/hedera-smart-contracts#936 for original issue.)

Issue reported for SELFDESTRUCT is that EIP-6780 clearly states that the target address for the sweep aka the beneficiary aka the obtainer (in our code for contract delete) can be the contract address itself and there are two cases:

• SELFDESTRUCT different transaction than contract created - this is the case where (post-cancun) the contract is not self destructed - contract keeps its balance
  • our behavior: return error SELF_DESTRUCT_TO_SELF - this is a bug as the contract/account is not deleted so it should work; in fact SELFDESTRUCT should work even if the account holds native (non-HBAR) tokens
• SELFDESTRUCT same transaction from contract created - this is the case where the contract is self destructed - "the Ether will be burnt"
  • our behavior: return SELF_DESTRUCT_TO_SELF - is this correct or not? do we have a way to burn HBAR? what happens if the contract account holds native tokens? Investigating this to see what the desired behavior is.

(The case of a HAPI ContractDelete call is that it always fails if there's a balance and the beneficiary is the contract account.)

Acceptance Criteria

• SELFDESTRUCT behavior unchanged except:
  • SELFDESTRUCT when beneficiary is same as contract being self-destructed, and contract self-destructed in different transaction than it was created (so contract is not deleted) will succeed even if account holds native tokens (it's a noop, except for gas charges).

Dependencies

No response

Definition of Ready (DoR) Checklist

• Clear acceptance criteria
• Clear and detailed description
• Dependencies identified
• Links to documentation
• Should be completable in 2-3 Days
• Initial draft of Low-level design document
• At least high level test plan
• Groomed/Estimated

Definition of Done (DoD) Checklist

• Acceptance Criteria complete
• No Codacy issues greater than minor (in new code)
• JavaDocs updated/created
• Code commented
• Unit tests created/updated
• 80% test code coverage (in new code)
• Happy Path and major negative cases in HAPI tests as applicable