Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash and sign only when app says so #17480

Open
lpetrovic05 opened this issue Jan 22, 2025 · 1 comment
Open

Hash and sign only when app says so #17480

lpetrovic05 opened this issue Jan 22, 2025 · 1 comment
Labels
Platform Tickets pertaining to the platform

Comments

@lpetrovic05
Copy link
Member

lpetrovic05 commented Jan 22, 2025

depends on #17463

Once handleConsensusRound returns a boolean, the platform should be modified to sign states only when the app returns true. We should still hash every state. A testing app can be modified to test this feature.

@lpetrovic05 lpetrovic05 added the Platform Tickets pertaining to the platform label Jan 22, 2025
@poulok
Copy link
Member

poulok commented Jan 22, 2025

We changed the epic ticket to hash EVERY state like we do today, but only to sign the state the app says to. The state hashing algorithm currently depends on every state being hashed, so we will keep it like that until we have cycles to adjust it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform
Projects
None yet
Development

No branches or pull requests

2 participants