Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valid start to Transaction Group Details #896

Open
jbair06 opened this issue Sep 10, 2024 · 1 comment · May be fixed by #1441
Open

Add valid start to Transaction Group Details #896

jbair06 opened this issue Sep 10, 2024 · 1 comment · May be fixed by #1441
Assignees
Labels
P3 Low priority issue. Will not impact the release schedule if not complete.
Milestone

Comments

@jbair06
Copy link
Member

jbair06 commented Sep 10, 2024

Problem

If the creator is creating a transaction group with lots of transactions (or just takes a long enough time creating the group), some transactions could have expired before the group is made. The creator would need to go through all transactions to manually ensure the valid start is still valid, in this case.

Solution

  • Add a valid start ticking (and editable) component to the Transaction Group Details page
  • Creating the transaction group would then update each transaction that has a valid start time older than the group's valid start time
  • Ensure that this functionality still separates each valid start time by a millisecond or so.

Alternatives

No response

@jbair06
Copy link
Member Author

jbair06 commented Sep 12, 2024

In the case of CSV import, this valid start would be the time in the CSV

@SimiHunjan SimiHunjan added this to the v0.6 milestone Dec 4, 2024
@SimiHunjan SimiHunjan added the P3 Low priority issue. Will not impact the release schedule if not complete. label Dec 4, 2024
@SimiHunjan SimiHunjan modified the milestones: v0.6, v0.7 Dec 18, 2024
@icoxxx icoxxx self-assigned this Dec 20, 2024
@icoxxx icoxxx linked a pull request Jan 13, 2025 that will close this issue
@icoxxx icoxxx linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low priority issue. Will not impact the release schedule if not complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants