From 572343c62c77cacb170d63256df03b599567dcd5 Mon Sep 17 00:00:00 2001 From: jarolrod Date: Thu, 9 Nov 2023 18:54:36 -0600 Subject: [PATCH 1/2] doc: update pr template Removes template for individual OS links in favor of one template link to the github actions page for the PR. --- .github/PULL_REQUEST_TEMPLATE.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index caa3a99bec..81264464c8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -43,10 +43,9 @@ patches often sit for a long time. --> From 90048be77c43bb53e3fdcb3a449ea1aefb60863c Mon Sep 17 00:00:00 2001 From: jarolrod Date: Thu, 9 Nov 2023 18:56:08 -0600 Subject: [PATCH 2/2] doc: update documentation around CI artifacts Update for the move to github actions, also mentions the new need to make the macOS binary executable. --- src/qml/README.md | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/qml/README.md b/src/qml/README.md index 9b51e1b8a5..d9b4798984 100644 --- a/src/qml/README.md +++ b/src/qml/README.md @@ -4,17 +4,13 @@ This directory contains the source code for an experimental Bitcoin Core graphical user interface (GUI) built using the [Qt Quick](https://doc.qt.io/qt-5/qtquick-index.html) framework. -Insecure CI artifacts are available for local testing of the master branch, avoiding the need to build: -- for Windows: [`insecure_win_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip) -- for Intel macOS: [`insecure_mac_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip) -- for Apple Silicon macOS: [`insecure_mac_arm64_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip) -- for ARM64 Android: [`insecure_android_apk.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip) +Unsecure CI artifacts are available for local testing of the master branch, avoiding the need to build. These can be found under the [Actions](https://github.com/bitcoin-core/gui-qml/actions?query=branch%3Amain) tab. It is required to have and be logged into a github account in order to download these. -Note: For Apple Silicon macOS machines, the binary must be signed before it can -be ran. To apply a signature, run the following on the unzipped CI artifact: +Note: For macOS, the CI artifact binary must be made executable and code-signed before it can +be ran. To make executable and apply a signature, run the following on the unzipped CI artifact: ``` -codesign -s - ./Downloads/insecure_mac_arm64_gui +chmod +x ./Downloads/bitcoin-qt && codesign -s - ./Downloads/bitcoin-qt ``` ## Goals and Limitations