Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback when origin is missing #49

Open
manpreeeeeet opened this issue Nov 30, 2023 · 3 comments
Open

Feedback when origin is missing #49

manpreeeeeet opened this issue Nov 30, 2023 · 3 comments

Comments

@manpreeeeeet
Copy link

Currently the ingest API returns 204 when it ingests a request with no matching origin. Do you think there should be a feedback to let users know of this?

@hjr3
Copy link
Owner

hjr3 commented Dec 31, 2023

There is feedback via the logs, but maybe we should consider this. What status could would you expect?

@hjr3
Copy link
Owner

hjr3 commented Dec 31, 2023

I think it would be a 404 or a 400.

If curl -H "Host: example.wh.soldr.dev" localhost:3000/ -d '' does not have a valid origin then a 404 makes the most sense.

@manpreeeeeet
Copy link
Author

I also think 404 makes the most sense since it's not a Bad request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants