Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ads #22

Open
22 tasks
humbertovnavarro opened this issue Sep 16, 2021 · 0 comments
Open
22 tasks

Feature: Ads #22

humbertovnavarro opened this issue Sep 16, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@humbertovnavarro
Copy link
Owner

⚙️ Feature

📐 Functionality

User will view unobtrusive adds at the bottom of the screen

🖼️ Wireframes

Wireframe screenshot(s) of what the app should look like when it is complete.

✅ Task List

Commit checklist for tasks needed to complete the feature.

🐘 Database

  • Update schema.sql to ...
  • Update data.sql to ...

☁️ Server

  • Update server/index.js to ...
  • Test with HTTPie
  • Handle all errors and respond to the client

⚡ Client

  • Create a component to ...
  • Update component to ...

🧑‍⚕️ Clean Up

  • ...
  • ...
  • Make sure that no React state objects are being mutated.
  • Make sure that no event listeners are manipulating the DOM directly.
  • Make sure that click targets are either <a> or <button> elements.
  • Make sure that all click targets show a cursor: pointer when hovered with the mouse.
  • Remove all buttons and placeholders that do not serve the functionality of the feature.
  • Remove all console logs.
  • Remove all commented out code.
  • Remove all CSS properties that have no effect.
  • Check all code for proper formatting and indentation.
  • Confirm that there are no errors in the console while using the application.
  • Confirm that all previous functionality still works without errors.
  • Confirm that the user interface looks natural on both mobile and desktop screens.
  • Create GIFs of the feature being used on both mobile and desktop screen sizes for inclusion in Pull Request.
@humbertovnavarro humbertovnavarro added the good first issue Good for newcomers label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant