Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helpers.create_subscription() Subscribes To Own Stdout/Stderr #34

Open
squatched opened this issue Aug 2, 2021 · 0 comments · May be fixed by #35
Open

helpers.create_subscription() Subscribes To Own Stdout/Stderr #34

squatched opened this issue Aug 2, 2021 · 0 comments · May be fixed by #35

Comments

@squatched
Copy link

I believe the appropriate response here is to return after this debug statement rather than dropping through to the next conditional. (Or change the next conditional from 'if' to 'elif'.)

# We cannot subscribe to the log group that our stdout/err goes to.
if context.log_group_name == log_group_name:
logger.debug("Skipping our own log group name...")
# And we do not want to subscribe to other Humio log ingesters - if there are any.
if "HumioCloudWatchLogsIngester" in log_group_name:

@squatched squatched linked a pull request Aug 2, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant