Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster lookup for processing big sdp : proposal #25

Open
charles-yubo opened this issue Feb 8, 2023 · 6 comments
Open

Faster lookup for processing big sdp : proposal #25

charles-yubo opened this issue Feb 8, 2023 · 6 comments

Comments

@charles-yubo
Copy link

Hi,
We recently went to unified-plan and I made some changes in my local to have faster code.
In particular for attributes, I created a pre check of beginning of the string (like rtmap) before calling the regex search.

Would you be interested for the addition?

Also I introduced some man made mapping for simple one to be faster+string_view.

Feel free to answer me there
Regards

@ibc
Copy link
Owner

ibc commented Feb 8, 2023

Sure.

@charles-yubo
Copy link
Author

Could string_view be used ?

@ibc
Copy link
Owner

ibc commented Feb 8, 2023

Could string_view be used ?

I'm afraid I don't know what that is.

@CharlesC87
Copy link

It is included in c++17 and consist in a pair of iterator that allow fats string (view) manipulation as long as originla string remains

@CharlesC87
Copy link

avoid creating of a lot of substrings ( less memory allocation : faster)

@CharlesC87
Copy link

First PR #26
(I am the same guy as charles-yubo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants