code: TODOs and FIXMES

[romac]

TODOs and FIXMEs

Generated on: 2025-01-22 18:56:04
Commit: d031b3a

Stats

• 9 FIXMEs
• 29 TODOs

FIXMEs

• code/crates/engine/src/wal/thread.rs:60

  // FIXME: Ensure this works even with fork_id
  

• code/crates/starknet/host/src/mempool.rs:132

  self.handle_network_msg(from, msg.clone(), myself, state) // FIXME: Clone
  

• code/crates/starknet/host/src/mempool.rs:220

  // FIXME: Remove only the given txes
  

• code/crates/starknet/p2p-types/src/proposal_part.rs:48

  proto::Protobuf::to_bytes(self).unwrap() // FIXME: unwrap
  

• code/crates/starknet/p2p-types/src/proposal_part.rs:52

  self.to_sign_bytes().len() // FIXME: Do something more efficient
  

• code/crates/test/src/proposal_part.rs:64

  proto::Protobuf::to_bytes(self).unwrap() // FIXME: unwrap
  

• code/crates/test/mbt/src/tests/consensus/runner.rs:74

  let some_other_node = self.address_map.get(OTHER_PROCESS).unwrap(); // FIXME
  

• code/examples/channel/src/state.rs:179

  return Ok(()); // FIXME
  

• code/examples/channel/src/app.rs:207

  value_bytes: ProtobufCodec.encode(&decided_value.value).unwrap(), // FIXME: unwrap
  

TODOs

• code/crates/sync/src/macros.rs:78

  // TODO: Add support for multiple patterns + if guards
  

• code/crates/sync/src/state.rs:30

  /// TODO - For now value and vote sync peers are the same. Might need to revise in the future.
  

• code/crates/sync/src/state.rs:54

  /// TODO - currently this is inferred from the fact that status was sent with height - 1
  

• code/crates/core-types/src/validator_set.rs:7

  /// TODO: Introduce newtype
  

• code/crates/core-types/src/certificate.rs:60

  pub aggregated_signature: AggregatedSignature<Ctx>, // TODO - type in context
  

• code/crates/app/src/part_store.rs:10

  // TODO: Add Address to key
  

• code/crates/app/src/lib.rs:1

  // TODO: Enforce proper documentation
  

• code/crates/app-channel/src/connector.rs:23

  // TODO: add some metrics
  

• code/crates/app-channel/src/lib.rs:3

  // TODO: Enforce proper documentation
  

• code/crates/config/src/lib.rs:402

  ProposalOnly, // TODO - add small block app to test this option
  

• code/crates/core-consensus/src/macros.rs:77

  // TODO: Add support for multiple patterns + if guards
  

• code/crates/core-consensus/src/state.rs:130

  // TODO optimization - get votes for all rounds higher than or equal to `round`
  

• code/crates/core-consensus/src/handle/proposed_value.rs:57

  // TODO: Keep unsigned proposals in keeper.
  

• code/crates/core-consensus/src/handle/decide.rs:59

  // TODO: should we verify we have 2/3rd commits?
  

• code/crates/core-consensus/src/handle/decide.rs:66

  // TODO: Revise when evidence module is added.
  

• code/crates/core-consensus/src/handle/proposal.rs:83

  // TODO - pass the received value up to the host that will verify and give back validity and extension.
  

• code/crates/starknet/host/src/mempool.rs:150

  // TODO: Log error
  

• code/crates/starknet/host/src/mempool.rs:278

  // TODO: Handle error
  

• code/crates/starknet/host/src/actor.rs:495

  // TODO - use state.host.receive_proposal() and move some of the logic below there
  

• code/crates/starknet/host/src/host/proposal.rs:154

  // TODO: Compute actual "proof"
  

• code/crates/starknet/host/src/host/starknet.rs:148

  todo!()
  

• code/crates/starknet/host/src/host/state.rs:120

  // TODO: we should probably still include height
  

• code/crates/starknet/host/src/host/state.rs:180

  // TODO: Add config knob for invalid blocks
  

• code/crates/starknet/host/src/host/state.rs:195

  // TODO: Do more validations, e.g. there is no higher tx proposal part,
  

• code/crates/starknet/p2p-types/src/transaction.rs:46

  /// TODO: Use hash function from Context
  

• code/crates/test/src/codec/json/raw.rs:17

  /// todo
  

• code/crates/test/mbt/src/tests/consensus/runner.rs:239

  // TODO: check expected_proposal.src_address
  

• code/crates/test/mbt/src/tests/consensus/runner.rs:319

  // TODO: What to do with actual.height? There is no height in the spec.
  

• code/crates/test/mbt/src/tests/votekeeper/runner.rs:120

  // TODO: check expected_round
  

[github-actions]

Last updated: 2025-01-22T18:56:05.883Z