Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

Follow up actions for #151 #296

Open
piotr-iohk opened this issue Feb 1, 2019 · 0 comments
Open

Follow up actions for #151 #296

piotr-iohk opened this issue Feb 1, 2019 · 0 comments
Labels
PROPOSED ADR just proposed

Comments

@piotr-iohk
Copy link
Contributor

Context

Remaining stuff to be done as a follow up to the #151.

  • improve on internal endpoints for better consistency ->

    • remove /api/internal/postpone-update, since it is has been turned into no-op
    • rename /api/internal/apply-update to /api/internal/restart-node since it is only restarting the node
  • manual procedure for proper test for nextUpdate to be done as part of this ticket (here? -> https://github.com/input-output-hk/cardano-wallet/tree/develop/test/manual)

  • create separate ticket for implementing integration test for nextUpdate (based on the manual procedure)

  • restartNode - implement integration test for the restartNode endpoint

Decision

The above actions need to be done ^^.

Acceptance Criterias

  1. /api/internal/postpone-update must be removed
  2. /api/internal/apply-update must be renamed to /api/internal/restart-node since it is only restarting the node
  3. /api/internal/apply-update should have a manual test procedure and a ticket for future automation
  4. /api/internal/restart-node should have an integration test

Development Plan

PR

Number Base
#? develop

QA

Criteria Coverage
? -

Retrospective

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PROPOSED ADR just proposed
Projects
None yet
Development

No branches or pull requests

1 participant