This repository has been archived by the owner on Mar 1, 2019. It is now read-only.
Make EO endpoints to manipulate EO wallets and FO to manipulate FO wallets only #336
Labels
ACCEPTED
ADR has been accepted
Context
While testing #331 we have observed that one can manipulate EOS wallets with FO endpoints and FO wallets with EOS endpoints. In particular:
GET /api/v1/wallets
.DELETE /api/v1/wallets/{walletId}
and FO withDELETE /api/v1/wallets/externally-owned/{walletId}
)GET /api/v1/wallets/{walletId}
(here you cannot do otherwise, and trying to get FO wallet with EOS enpoint results inWalletNotFound
- which is expected I suppose)There were integration tests added for that under #331, they are currently failing:
Decision
Manipulation with EO wallets must be restricted only to EO endpoints.
Manipulation with FO wallets must be restricted only to FO endpoints.
Acceptance Criterias
See ^.
Integration tests mentioned here should pass.
Development Plan
PR
develop
develop
QA
Retrospective
The text was updated successfully, but these errors were encountered: