Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm staged deps #325

Merged
merged 5 commits into from
Oct 28, 2024
Merged

rm staged deps #325

merged 5 commits into from
Oct 28, 2024

Conversation

shajoezhu
Copy link
Contributor

close #324

@shajoezhu shajoezhu added the sme Tracks changes for the sme board label Oct 25, 2024
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Unit Tests Summary

  1 files    8 suites   15s ⏱️
 52 tests  52 ✅ 0 💤 0 ❌
365 runs  365 ✅ 0 💤 0 ❌

Results for commit e737181.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 25, 2024

badge

Code Coverage Summary

Filename             Stmts    Miss  Cover    Missing
-----------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/format_value.R       197      12  93.91%   88, 105-112, 187, 204, 409, 423, 431
R/generics.R           125      12  90.40%   142, 280-284, 486, 498, 529, 559, 667, 680, 701-708
R/labels.R              55       7  87.27%   51, 57, 66, 107, 133, 142, 146
R/matrix_form.R        688      41  94.04%   121, 383, 503-504, 596, 606-609, 627, 658, 748-749, 763-768, 798-801, 861-862, 951-952, 979, 1007, 1059, 1221, 1257, 1260-1264, 1314, 1362, 1365, 1369
R/mpf_exporters.R      277      20  92.78%   2, 100-102, 147, 183, 227, 230, 235, 414-420, 424, 427, 431, 479, 557
R/page_size.R           42       1  97.62%   219
R/pagination.R         759      52  93.15%   327-330, 435-450, 540, 593, 598, 639, 677-688, 764, 876-877, 899-908, 1046, 1097-1098, 1249, 1286-1290, 1306, 1313, 1395, 1530-1531, 1547-1548, 1562-1563
R/tostring.R           783      66  91.57%   88, 296, 351, 421, 454, 462, 498, 555-558, 594, 658-661, 667-671, 674-677, 684-689, 772-773, 913-914, 979-986, 1036-1040, 1109, 1162, 1181-1185, 1196, 1214, 1231, 1246, 1344, 1385, 1430, 1516, 1555, 1609, 1616
R/utils.R                3       0  100.00%
R/zzz.R                 17       6  64.71%   28-33
TOTAL                 2946     217  92.63%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: e737181

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@pawelru
Copy link
Collaborator

pawelru commented Oct 25, 2024

In the current form this would break CI. Unless you change .github/workflows/check.yaml file, staged.deps continue to be used and that file continue to be required.

@shajoezhu
Copy link
Contributor Author

In the current form this would break CI. Unless you change .github/workflows/check.yaml file, staged.deps continue to be used and that file continue to be required.

sure. I will add the line

  deps-installation-method: setup-r-dependencies

as I started with a few repos that were at the root of the dependency tree

@pawelru
Copy link
Collaborator

pawelru commented Oct 28, 2024

This looks good! I can see that the new way is being used right now 👍

@pawelru pawelru self-assigned this Oct 28, 2024
@shajoezhu shajoezhu merged commit 40c0c3c into main Oct 28, 2024
30 checks passed
@shajoezhu shajoezhu deleted the 324_rm_stagedep branch October 28, 2024 08:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sme Tracks changes for the sme board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

formatters switch from staged-dependencies to setup-r-dependencies for deps install
2 participants