Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all CI pipelines are green before release #98

Open
donyunardi opened this issue Jan 3, 2025 · 11 comments
Open

Make sure all CI pipelines are green before release #98

donyunardi opened this issue Jan 3, 2025 · 11 comments
Assignees
Labels

Comments

@donyunardi
Copy link
Collaborator

donyunardi commented Jan 3, 2025

Summary

Review all CI/CD pipeline (daily, Scheduled, etc) and make sure it's green before release.

Priority 1 - the frameworks

  • teal.code
  • teal.widgets
  • teal.data
  • teal.reporter
  • teal.slice
  • teal.transform
  • teal

Priority 2

  • tmg
  • tmc

Priority 3

  • osprey
  • teal.osprey
  • goshawk
  • teal.goshawk
  • hermes
  • teal.modules.hermes
  • helios
  • tel.modules.helios
@donyunardi
Copy link
Collaborator Author

donyunardi commented Jan 3, 2025

teal.widgets ✅

Only Dependency Test - max failed in Scheduled pipeline

Assuming we're not adding formatters to teal.widgets dependency, this workflow will continue to fail until newest rtables/formatters are released.

teal.code ✅

revdepcheck failed because it's trying to run the teal.data 0.6.0 unit tests against teal.code main branch:
https://github.com/insightsengineering/teal.code/actions/runs/12532241545/job/34950765175

I believe this will go away once we release teal.data.

teal.data ✅

We have issue with min isolated test:

Only release is failing which is expected and will be resolved once we release teal.code:
https://github.com/insightsengineering/teal.data/actions/runs/12714861412

teal.slice

min_cohort is failing:
https://github.com/insightsengineering/teal.slice/actions/runs/12714930133/job/35446110038

teal.transform

teal.reporter

teal

@shajoezhu
Copy link
Collaborator

hi @donyunardi , we will release new formatters/rtables this month, perhaps we should meet and discuss

@m7pr
Copy link

m7pr commented Jan 13, 2025

Just reviewed Priority 1 list and here is the status

Passing:

  • 🟢 teal.code failing in revdepcheck link but will pass once teal.data is released
  • 🟢 teal.logger - all fine link
  • 🟢 teal.widgets all fine link

Failing: - Error in deferred_run(env) : could not find function "deferred_run"

  • 🟥 teal.slice - failing in Dependency Tests link
  • 🟥 teal failing in all 4 Dependency Tests link
  • 🟥 teal.data failing in Dependency Test - release link
  • 🟥 teal.reporter failing in Dependency Tests - release and min_isolated link
  • 🟥 teal.transform failing in all 4 Dependency Tests link

@m7pr m7pr self-assigned this Jan 13, 2025
@m7pr
Copy link

m7pr commented Jan 13, 2025

Experimented with teal.data and I was able to overcome the issue

Error in deferred_run(env) : could not find function "deferred_run"

by loading withr at the beginning of the action's script
insightsengineering/r-verdepcheck-action#24

I will now restart all jobs that were failing

@m7pr
Copy link

m7pr commented Jan 14, 2025

Current Priority 1 list status

Passing:

  • 🟢 teal.logger - all fine link
  • 🟢 teal.widgets all fine link

Failing but will pass once teal.code and teal.data are released:

  • 🟢 teal.data
  • 🟢 teal.transform
  • 🟢 teal.code

Failing:

  • 🟥 teal.slice - failing in min_isolated link can not install SummarizedExperiment
  • 🟥 teal failing in all 3 Dependency Tests link can't install rtables
  • 🟥 teal.reporter failing in min_isolated link 5 tests are failing

@m7pr
Copy link

m7pr commented Jan 14, 2025

Latest update

Current Priority 1 list status

Passing:

  • 🟢 teal.logger - all fine link
  • 🟢 teal.widgets all fine link
  • 🟢 teal.reporter failing only in release strategy

Failing but will pass once teal.code and teal.data are released:

  • 🟢 teal.data
  • 🟢 teal.transform
  • 🟢 teal.code

Failing:

  • 🟥 teal.slice - failing in min_isolated link can not install SummarizedExperiment
  • 🟥 teal failing in all 3 Dependency Tests link can't install rtables

@m7pr
Copy link

m7pr commented Jan 15, 2025

Latest update

Current Priority 1 list status

Passing:

  • 🟢 teal.logger all fine link
  • 🟢 teal.widgets all fine link
  • 🟢 teal.reporter failing only in release strategy
  • 🟢 teal.slice failing only in release strategy

Failing but will pass once teal.code and teal.data are released:

  • 🟢 teal.data
  • 🟢 teal.transform
  • 🟢 teal.code

Failing:

  • 🟥 teal failing in all 3 Dependency Tests link can't install rtables

m7pr added a commit to insightsengineering/teal.slice that referenced this issue Jan 15, 2025
Part of insightsengineering/nestdevs-tasks#98

`extra-deps` was badly formed

---------

Signed-off-by: André Veríssimo <[email protected]>
Co-authored-by: Marcin <[email protected]>
Co-authored-by: m7pr <[email protected]>
@m7pr
Copy link

m7pr commented Jan 15, 2025

Latest update

Current Priority 1 list status

Passing:

  • 🟢 teal.logger all fine link
  • 🟢 teal.widgets all fine link
  • 🟢 teal.reporter failing only in release strategy
  • 🟢 teal.slice failing only in release strategy
  • 🟢 teal failing only in release strategy

Failing but will pass once teal.code and teal.data are released:

  • 🟢 teal.data
  • 🟢 teal.transform
  • 🟢 teal.code

@m7pr
Copy link

m7pr commented Jan 15, 2025

Will continue with tmg and tmc right now

m7pr added a commit to insightsengineering/teal that referenced this issue Jan 15, 2025
@m7pr
Copy link

m7pr commented Jan 16, 2025

@m7pr
Copy link

m7pr commented Jan 16, 2025

For both tmg and tmc I am struggling with inability to install teal.slice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants