Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.nmake only builds Release configuration, resulting in mixed CRT warning in VS #120

Open
gh-andre opened this issue Apr 8, 2023 · 0 comments

Comments

@gh-andre
Copy link

gh-andre commented Apr 8, 2023

Visual C++ expects different MSVC CRT options for Debug and Release builds and current Makefile.nmake builds only libraries for Release configurations. I realize that it's generated from tools/gen_nmake.mk and I didn't look into how it is plugged in for a PR, but if you are interested in a patch, in general, here's one for Makefile.nmake:

https://github.com/StoneStepsInc/isa-lib-crypto-nuget/blob/master/patches/01-nmake-debug-release.patch

With this patch, one can build Debug/Release libraries like this:

nmake -f Makefile.nmake CONFIG=DEBUG
nmake -f Makefile.nmake CONFIG=RELEASE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant