-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v2 code to use Canteloupe and BookReader #16
Comments
Thanks @mprove. We will look into this but its possibly to do with our routing in the new version. |
The first of these examples is loading fine for me running the code locally, but not on the deployed main branch code on ux-fnf-misc so I'm at a bit of a loss. We might need the error logs from that service to work out what is going on. The second one is erroring because the image is too large and PIL is throwing a warning about a potential decompression bomb. It seems like the old v2 code still has a call that ends up downloading and parsing the image in order to get the dimensions: https://github.com/internetarchive/iiif/blob/main/iiify/resolver.py#L208 This eventually leads to I think it's probably out of scope for us to fix this right now as our work is focused on the v3 APIs, but if we have some time later we could look at replacing that |
ok. Prio & severity should be lowest. Won't fix is fine with me as well. |
Call Cantaloupe or book reader to get dimensions rather than downloading the images. |
For the item https://archive.org/details/opencontext-41-nippur-excavation-units
But v2 is not yet online
Same for https://archive.org/details/dr_sheet-1-2-bildplanskizze-der-stadt-kiew-120-000-10839003
ok: https://iiif.archive.org/iiif/dr_sheet-1-2-bildplanskizze-der-stadt-kiew-120-000-10839003/manifest.json
not found: https://iiif.archive.org/iiif/2/dr_sheet-1-2-bildplanskizze-der-stadt-kiew-120-000-10839003/manifest.json
The text was updated successfully, but these errors were encountered: