From 4a4a64aa4e69052c63ea1b12c49bae93c3ad74fb Mon Sep 17 00:00:00 2001 From: Tarrence van As Date: Fri, 11 Sep 2020 14:17:16 -0400 Subject: [PATCH] chore(deps): bump webrtc (#150) --- go.mod | 2 +- go.sum | 2 ++ pkg/webrtctransport.go | 13 +++++++------ 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/go.mod b/go.mod index a6a3189b9..3ee4fe339 100644 --- a/go.mod +++ b/go.mod @@ -10,7 +10,7 @@ require ( github.com/pion/rtp v1.6.0 github.com/pion/sdp/v2 v2.4.0 github.com/pion/transport v0.10.1 - github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911055832-fc11e7c66cff + github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911180519-81cfadaf06cb github.com/rs/zerolog v1.19.0 github.com/sourcegraph/jsonrpc2 v0.0.0-20200429184054-15c2290dcb37 github.com/spf13/viper v1.7.1 diff --git a/go.sum b/go.sum index 123892866..0fea9ace7 100644 --- a/go.sum +++ b/go.sum @@ -277,6 +277,8 @@ github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200910131025-c2ed6ee8350d h1:bLRBuJW github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200910131025-c2ed6ee8350d/go.mod h1:stOX+uPii8HN/Qqc/fXpbCyXp2fgKa/bMR6BHO3rF4I= github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911055832-fc11e7c66cff h1:htjaEjrEL8udfZuEUjAu/XRj+KJfhfdQji73GN+ml6U= github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911055832-fc11e7c66cff/go.mod h1:stOX+uPii8HN/Qqc/fXpbCyXp2fgKa/bMR6BHO3rF4I= +github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911180519-81cfadaf06cb h1:9ZudR3bNMttmxXB70EIY3+lxuTPoBrvVgVHZvc4AHfw= +github.com/pion/webrtc/v3 v3.0.0-beta.4.0.20200911180519-81cfadaf06cb/go.mod h1:stOX+uPii8HN/Qqc/fXpbCyXp2fgKa/bMR6BHO3rF4I= github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4= diff --git a/pkg/webrtctransport.go b/pkg/webrtctransport.go index 1fbca99e3..4814aca95 100644 --- a/pkg/webrtctransport.go +++ b/pkg/webrtctransport.go @@ -244,12 +244,13 @@ func (p *WebRTCTransport) NewSender(intrack *webrtc.Track) (Sender, error) { // Create webrtc sender for the peer we are sending track to sender := NewWebRTCSender(p.ctx, outtrack, s) - sender.OnClose(func() { - err = p.pc.RemoveTrack(s) - if err != nil { - log.Errorf("Error closing sender: %s", err) - } - }) + // TODO: remove once resolved https://github.com/pion/webrtc/issues/1343 + // sender.OnClose(func() { + // err = p.pc.RemoveTrack(s) + // if err != nil { + // log.Errorf("Error closing sender: %s", err) + // } + // }) return sender, nil }