Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect docs regarding creating text snippets #15

Open
spookylukey opened this issue Mar 31, 2018 · 0 comments
Open

Incorrect docs regarding creating text snippets #15

spookylukey opened this issue Mar 31, 2018 · 0 comments

Comments

@spookylukey
Copy link

The README claims:

You can use any logic you like for the text snippets: constants, functions...

As far as I can see this is incorrect. The method relies on parsing Elm source code for a fixed set of constructs (concatenation etc.) in order to generate strings. Anything outside that will not work when it comes to the translated versions - doing something as simple as adding brackets to an expression makes it fail - and it's pretty unclear to me how it could ever be made to work with arbitrary functions.

Maybe this should be:

You can use Elm syntax for the text snippets (with a fixed set of constructs including concatenation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant