Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] multiple domains or alternative domains in config file #5002

Open
mooleshacat opened this issue Oct 12, 2024 · 3 comments
Open
Labels
enhancement Improvement of an existing feature

Comments

@mooleshacat
Copy link

mooleshacat commented Oct 12, 2024

Is your enhancement request related to a problem? Please describe.

Related: #1421
Related comment: #1421 (comment)

Would be nice to have ability to set multiple domains in the config file

  • Ex. "invidious.catspeed.cc" "us.invidious.catspeed.cc" "ca.invidious.catspeed.cc" "mx.invidious.catspeed.cc" "catspeed.i2p" "akjhgaldhfgljkadfg.onion"

Describe the solution you'd like

Would be nice to have ability to set multiple domains in the config file

  • Ex. "invidious.catspeed.cc" "us.invidious.catspeed.cc" "ca.invidious.catspeed.cc" "mx.invidious.catspeed.cc" "catspeed.i2p" "akjhgaldhfgljkadfg.onion"

Describe alternatives you've considered

none
attempt myself

Additional context

I was thinking it would be good feature. I searched for existing issue ticket and none exist only this part of a users comment mentioned briefly.

          Maybe invidious could support serving two domains at the same time.

Originally posted by @Perflyst in #1421 (comment)

also this comment

          @FireMasterK Ideally invidious should support multiples domain names (or 1 domain name + 1 tor onion). A solution with nginx is "good" but far from ideal.

Originally posted by @TheFrenchGhosty in #1421 (comment)

You could probably then add in your i2p address to the list there as well

Note: this would break video playback (dash) if your domain is not specified in config.

@Fijxu
Copy link
Contributor

Fijxu commented Oct 14, 2024

I actually tried to implement it on my instance. This is a very early commit that didn't work too well but you can take it as a POC and fix it if you want. I don't remember what is broken tho.

https://git.nadeko.net/Fijxu/invidious/commit/100ecff0b371ef7bd4228d69ef1180f55e5d3a9a

@mooleshacat
Copy link
Author

mooleshacat commented Oct 18, 2024

Greatly appreciate it 👍 I will look at cherry picking it.

You know there is a bounty you can claim if you did get it working :) I'd even send you $15usd myself if you want

@unixfox
Copy link
Member

unixfox commented Oct 18, 2024

It's not easy to implement because the domain is used in several places:

  • the frontend
  • pubsubsub functionality
  • rss feeds

Alternative domains like @Fijxu is proposing is probably the better approach.

@unixfox unixfox changed the title [Enhancement] multiple domains in config file [Enhancement] multiple domains or alternative domains in config file Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants