From 3984a8fb26f865df53a0c7ac9fc6114e20c7a83b Mon Sep 17 00:00:00 2001 From: jakthom Date: Fri, 8 Nov 2024 21:01:55 -0500 Subject: [PATCH 1/3] don't run post start cmd without a terminal --- .devcontainer/devcontainer.json | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 .devcontainer/devcontainer.json diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json deleted file mode 100644 index 58c90f6..0000000 --- a/.devcontainer/devcontainer.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "postStartCommand": "CGO_ENABLED=1 ENV=$(whoami) go run -ldflags=\"-X 'main.VERSION=$(cat .VERSION)'\" ./cmd/hercules/" -} \ No newline at end of file From 749066507b5da2e7bfd87d3fa999c603974ebb3b Mon Sep 17 00:00:00 2001 From: jakthom Date: Thu, 14 Nov 2024 07:50:08 -0500 Subject: [PATCH 2/3] use older ubuntu b/c sporadic lint errors --- .github/workflows/lint.yml | 4 ++-- .github/workflows/test.yml | 4 ++-- README.md | 4 +++- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 0df5e3f..7107a9b 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -13,11 +13,11 @@ permissions: jobs: run-lint: - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - uses: actions/setup-go@v5 with: - go-version: 1.22 + go-version: 1.23 - uses: actions/checkout@v4 - uses: golangci/golangci-lint-action@v6 with: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 26a00ba..14fffa9 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -3,12 +3,12 @@ on: [push] jobs: run-tests: - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v4 - name: Setup Go uses: actions/setup-go@v5 with: - go-version: "1.22" + go-version: 1.23 - name: Test with the Go CLI run: make test diff --git a/README.md b/README.md index 381afdd..3823bf1 100644 --- a/README.md +++ b/README.md @@ -17,10 +17,12 @@ -# Getting Started +# ⚡ Quickstart Launching Hercules in a Codespace is the easiest way to get started. +A `make run` from inside your codespace will get things spinning. + [![Launch GitHub Codespace](https://github.com/codespaces/badge.svg)](https://github.com/codespaces/new?hide_repo_select=true&ref=main&repo=873715049) From 3a5a0d5d11a1a26d4c65342734755839dca40d31 Mon Sep 17 00:00:00 2001 From: jakthom Date: Thu, 14 Nov 2024 07:54:31 -0500 Subject: [PATCH 3/3] bump ci lint version --- .github/golangci.yml | 2 +- .github/workflows/lint.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/golangci.yml b/.github/golangci.yml index 4fa79f7..9f5eef1 100644 --- a/.github/golangci.yml +++ b/.github/golangci.yml @@ -1,3 +1,3 @@ run: timeout: 10m - go: "1.22" + go: 1.23 diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 7107a9b..6f8f22a 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -21,5 +21,5 @@ jobs: - uses: actions/checkout@v4 - uses: golangci/golangci-lint-action@v6 with: - version: v1.59.1 + version: v1.62.0 args: --config ./.github/golangci.yml ./pkg/... ./cmd/...