Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using uint64 types #3

Open
stuarteberg opened this issue Apr 12, 2019 · 0 comments
Open

Stop using uint64 types #3

stuarteberg opened this issue Apr 12, 2019 · 0 comments

Comments

@stuarteberg
Copy link
Member

We should start using int64 instead of uint64 wherever possible, since implicit conversions between the two can trip up commonly used libraries, and also cause subtle problems when serializing to language-agnostic formats, such as json, protobuf, and sqlite.

More crucially, the use of uint64 prevents us from using the numexpr library (or even having it installed), which is the preferred engine for pandas.DataFrame.query().

In practice, we never use the sign bit in our sv/body IDs, so there should be no problem switching to int64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant