Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh_from_array() does not include normals #2

Open
stuarteberg opened this issue Oct 25, 2017 · 0 comments
Open

mesh_from_array() does not include normals #2

stuarteberg opened this issue Oct 25, 2017 · 0 comments

Comments

@stuarteberg
Copy link
Member

The mesh_from_array() function obtains vertices, normals, and faces from the marching_cubes library:

 vertices_xyz, _normals, faces = march(volume_xyz, smoothing_rounds)

...but we don't actually write the normals into the .obj file. Apparently this creates a performance issue for NeuTu.

Someone should investigate whether or not there is a good reason we're not writing the normals. (Are the normals incorrect? Do they pose a problem for fq-mesh-simplify or draco_encoder?)

Unless there's a compelling reason not to, we should write the normals into the .obj instead of simply discarding them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant