Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mini_magick 5.0.0 #125

Open
jmaino opened this issue Jul 9, 2024 · 9 comments
Open

Support mini_magick 5.0.0 #125

jmaino opened this issue Jul 9, 2024 · 9 comments

Comments

@jmaino
Copy link

jmaino commented Jul 9, 2024

the gemspec currently restricts mini_magick to (>= 4.9.5, < 5), which prevents the update to the newly released 5.0.0 .

@janko
Copy link
Owner

janko commented Jul 9, 2024

Yes, I plan on doing that 👍🏻 That version constraint was intentional, as there will be changes needed to support MiniMagick 5.

@bvogel
Copy link

bvogel commented Aug 27, 2024

Any news here? Love your work.

@janko
Copy link
Owner

janko commented Aug 27, 2024

What specific functionality are you eager to get from MiniMagick 5.0? I'm not in a rush because that release was mostly about removing deprecated stuff.

@bvogel
Copy link

bvogel commented Aug 28, 2024

No rush, just a policy that we should avoid any library we use to fall two major releases behind, and as some are quite slow I got in the habit to keep up upon things. But taking this is on your roadmap, I'm fine waiting...

@Hessah95
Copy link

Hessah95 commented Sep 1, 2024

Hello... will this update be released soon?

@bvogel
Copy link

bvogel commented Sep 1, 2024

@Hessah95 you may have misunderstood this. This is only an issue discussing the possibility to even start an update to mini_magick v5. There is currently no code supporting this, you are free to open a PR to add support for this upgrade.

@jorihardman-aumni
Copy link

Alpine linux has updated imagemagick to >v7 which fully deprecates functionality used by mini_magick <5. In order to support our production docker images which run on alpine, we'd like to upgrade mini_magick to 5.X but cannot due to image_processing version restrictions. I'm not saying that this should drive prioritization of this issue, but I wanted to provide some context that will be shared with anyone using alpine docker images for deploying ruby apps.

@janko
Copy link
Owner

janko commented Oct 4, 2024

Are you referring only to the convert => magick deprecation? That shouldn't issue deprecation warnings on MiniMagick < 5, MiniMagick should be silencing those.

But yeah, that's additional reason for me to get moving with the MiniMagick 5.x support 👍🏻

@lukeasrodgers
Copy link

I have a PR here #132 that begins this work. Happy to get feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants