Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magicsort can't work properly #1

Open
eribertomota opened this issue Nov 28, 2018 · 3 comments
Open

magicsort can't work properly #1

eribertomota opened this issue Nov 28, 2018 · 3 comments
Labels
good first issue Good for newcomers

Comments

@eribertomota
Copy link
Contributor

eribertomota commented Nov 28, 2018

The current data output by modern file(1) command can be very large. As example, see some directories created by magicsort:

# ls -l
drwxr-xr-x 2 root     root       4096 nov 28 21:29 'JPEG image data, JFIF standard 1.01, aspect ratio, density 72x72, segment length 16, Exif Standard: [TIFF image data, big-endian, direntries=4, orientation=upper-left, xresolution=62, yresolution=70], progressive, precision 8, 1440x1080, frames 3'
drwxr-xr-x 2 root     root       4096 nov 28 21:29 'PNG image data, 1697 x 2400, 8-bit_color RGBA, non-interlaced'
drwxr-xr-x 2 root     root       4096 nov 28 21:29 'PNG image data, 765 x 812, 8-bit_color RGBA, non-interlaced'
drwxr-xr-x 2 root     root       4096 nov 28 21:29 'PNG image data, 960 x 600, 8-bit colormap, non-interlaced'

The Debian bug #610158, available here[1], tells magicsort command sometimes gives errors saying "cannot remove : no such file or directory."

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610158

Thanks,

Eriberto

@jbj jbj added the good first issue Good for newcomers label Dec 2, 2018
@jbj
Copy link
Owner

jbj commented Dec 2, 2018

I can see this would happen if magicsort is used on a Windows file system such as FAT, where file names must be short and can't contain quotes and certain other characters. It's also sensible to truncate the output from file to a reasonable length in any case.

@eribertomota
Copy link
Contributor Author

Do you intent to fix it?

Thanks for your nice work.

@jbj
Copy link
Owner

jbj commented Dec 6, 2018

I have no plans to fix this myself. Contributions will be gratefully considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants