Shouldn't the change be made immutable after bookmark set and push?

[xoich]

I see now that only

I found a surprising behavior.

I have added a few changes to the develop bookmark, then I want to push these to git. So I do jj bookmark set develop and jj git push.

What happens: develop@origin is set in the current change and is mutable
What I expect instead: develop@origin is set to the current change, it is made immutable and so a new change is added on top of it.

Is the behavior normal?

This has now caused me many time troubles when I started modifying the working copy and so adding a new hidden commit on the develop@origin change.

[xoich]

I see now that only the trunk() branch is immutable. It's a bit of a confusing default when more than one branch is used for shared development in a team. But I'm not sure how it could be done differently.

[bnjmnt4n]

The default set of immutable heads is builtin_immutable_heads(), which in turn is defined as present(trunk()) | tags() | untracked_remote_bookmarks().

All untracked remote bookmarks are immutable by default. Once you start tracking a remote bookmark, it will become mutable.

[xoich]

I see thanks, but why the only the ones that are not tracked?

[martinvonz]

All untracked remote bookmarks are immutable by default. Once you start tracking a remote bookmark, it will become mutable.

Maybe I'm misreading this, but a commit with a remote bookmark pointing to it will be immutable even if you start tracking the remote bookmark, right?

[yuja]

a commit with a remote bookmark pointing to it will be immutable even if you start tracking the remote bookmark

No, PR branch should be kept mutable after pushing, for example. The rationale is that tracked remote bookmarks are usually your branches, so they're mutable by default.

[martinvonz]

Oh, that's what untracked_remote_bookmarks() is for. I had completely forgotten that we had that in addition to remote_bookmarks(). Sorry.