Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move out configuration params from params #6

Open
jkaflik opened this issue Sep 12, 2023 · 1 comment
Open

Move out configuration params from params #6

jkaflik opened this issue Sep 12, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jkaflik
Copy link
Owner

jkaflik commented Sep 12, 2023

At the moment everything lies in a single src/openmower/config directory. It should be split into two:

  • ROS node & URDF params
  • actual configuration
@jkaflik jkaflik added the good first issue Good for newcomers label Sep 12, 2023
@rovo89
Copy link

rovo89 commented May 1, 2024

Are you planning to add some override or extension mechanism? Some parameters will be different between mowers. Some will be different depending on the individual build. For example, I'm using a UM980 connected via USB, so I'll need to change the GPS device and baud rate.

I assume I would have to copy the whole gps.yml and change the values? Or even all the config files?

If on the other hand the user-maintained config files just contained the changed values, it's more easily possible to change defaults and it's clear to see the deviations from the standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants