Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication between Should* and ShouldNot* error message factories #57

Open
fbiville opened this issue May 20, 2020 · 0 comments
Open

Reduce duplication between Should* and ShouldNot* error message factories #57

fbiville opened this issue May 20, 2020 · 0 comments
Labels
good first issue

Comments

@fbiville
Copy link
Collaborator

fbiville commented May 20, 2020 •
edited
Loading

Only 1 class per attribute with 2 methods is enough.

See e.g. org.assertj.neo4j.error.ConstraintTypeErrorMessageFactory with 2 public methods:

  • shouldBeOfConstraintType
  • shouldNotBeOfConstraintType.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fbiville