Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Varnish version reported #37

Closed
Katoga opened this issue Oct 18, 2018 · 1 comment · Fixed by #38
Closed

Wrong Varnish version reported #37

Katoga opened this issue Oct 18, 2018 · 1 comment · Fixed by #38

Comments

@Katoga
Copy link
Contributor

Katoga commented Oct 18, 2018

  • Varnish 4.1.10
  • prometheus_varnish_exporter 1.4.1

Exporter wrongly reports Varnish version, it shows only first digit of patch number.

Running with Varnish v4.1.10 shows following log messages:

2018/10/18 19:17:22 prometheus_varnish_exporter v1.4.1 (7c2b385) {
  "ListenAddress": ":9131",
  "Path": "/metrics",
  "HealthPath": "",
  "VarnishstatExe": "varnishstat",
  "VarnishDockerContainer": "",
  "Params": {
    "Instance": "",
    "VSM": ""
  },
  "Verbose": false,
  "NoExit": true,
  "Test": false,
  "Raw": false,
  "WithGoMetrics": false
}
2018/10/18 19:17:22 Found varnishstat 4.1.1 1d090c5a08f41c36562644bafcce9d3cb85d824f
2018/10/18 19:17:22 Test scrape done in 6.390321ms

2018/10/18 19:17:22 Server starting on :9131 with metrics path /metrics
Katoga pushed a commit to Katoga/prometheus_varnish_exporter that referenced this issue Oct 18, 2018
jonnenauhaGH-37 Add version test for Varnish 4.1.10
59168a2
Katoga pushed a commit to Katoga/prometheus_varnish_exporter that referenced this issue Oct 18, 2018
jonnenauhaGH-37 Fix version parsing regex
d12e3ae
Katoga pushed a commit to Katoga/prometheus_varnish_exporter that referenced this issue Oct 18, 2018
jonnenauhaGH-37 Improve regex matching of Varnish version
9662b25
Katoga added a commit to Katoga/prometheus_varnish_exporter that referenced this issue Oct 18, 2018
@Katoga
jonnenauhaGH-37 Add version test for Varnish 4.1.10
5264386
Katoga added a commit to Katoga/prometheus_varnish_exporter that referenced this issue Oct 18, 2018
@Katoga
jonnenauhaGH-37 Fix version parsing regex
774f3a8
Katoga added a commit to Katoga/prometheus_varnish_exporter that referenced this issue Oct 18, 2018
@Katoga
jonnenauhaGH-37 Improve regex matching of Varnish version
f91d923
@jonnenauha
Copy link
Owner

Looks like you fixed it yourself. You wanna send a PR here?

@Katoga Katoga mentioned this issue Oct 18, 2018
Merged
jonnenauha pushed a commit that referenced this issue Oct 21, 2018
@Katoga
Fix Varnish version reporting (#38)
2a5daa5 
* GH-37 Add version test for Varnish 4.1.10

* GH-37 Fix version parsing regex

* GH-37 Improve regex matching of Varnish version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Varnish version reporting Katoga/prometheus_varnish_exporter
2 participants
@jonnenauha @Katoga