Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox find-as-you-type blocks keyboard shortcuts #473

Open
nschneid opened this issue Mar 9, 2022 · 3 comments
Open

Firefox find-as-you-type blocks keyboard shortcuts #473

nschneid opened this issue Mar 9, 2022 · 3 comments

Comments

@nschneid
Copy link

nschneid commented Mar 9, 2022

E.g. R to set the root, which appears to be handled at:

case (KEYS.R):
if ($(".activated").length)
graph.setRoot($(".activated"));
break;

Is there a missing event.preventDefault()?

Is there alternative way to set the root?

@nschneid
Copy link
Author

nschneid commented Mar 9, 2022

(A hacky workaround: app.graph.setRoot($(".activated")); in the console)

@ftyers
Copy link
Collaborator

ftyers commented Mar 9, 2022

@nschneid does event.preventDefault() work there as a fix? If so I can add it, or you could make a PR.

@nschneid
Copy link
Author

nschneid commented Mar 9, 2022

I see it is being called in some places in that file. I don't know what the correct logic should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants