Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging package version bumps #486

Open
jonorthwash opened this issue Jun 15, 2022 · 1 comment
Open

merging package version bumps #486

jonorthwash opened this issue Jun 15, 2022 · 1 comment

Comments

@jonorthwash
Copy link
Owner

jonorthwash commented Jun 15, 2022

Is merging all the package version bumps safe, @keggsmurph21? (See open PRs)

I worry that some things have changed major version number, e.g. ejs from version 2 to version 3.

I also worry that we have a lot of dependencies. Are all of these necessary? I see things like tar and ini which seem unrelated to what Annotatrix does.

@keggsmurph21
Copy link
Collaborator

Is merging all the package version bumps safe, @keggsmurph21? (See open PRs)

I worry that some things have changed major version number, e.g. ejs from version 2 to version 3.

We'd probably need to look closely at the major version bumps, but any others should be safe. And I guess when I say "look closely" I just mean (1) make the change locally, (2) check if broken, (3) otherwise merge it in. Up to you how you want to ensure (2) 😁

I also worry that we have a lot of dependencies. Are all of these necessary?

Haha, probably not all of them. It is worth noting that most of our dependencies are actually "dev dependencies", which means the end user never needs to use them (or even know about them).

I see things like tar and ini which seem unrelated to what Annotatrix does.

Yeah, these are both dev dependencies. You can see why they're in the package-lock.json if you run these commands:

$ npm ls tar
[email protected] /home/kevinmurphy/src/jonorthwash/ud-annotatrix
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]
$ npm ls ini
[email protected] /path/to/ud-annotatrix
├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └─┬ [email protected]
│         └─┬ [email protected]
│           └─┬ [email protected]
│             └── [email protected] deduped
├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └── [email protected] deduped
├─┬ [email protected] -> ./notatrix
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └─┬ [email protected]
│         └─┬ [email protected]
│           └─┬ [email protected]
│             └─┬ [email protected]
│               └── [email protected]
└─┬ [email protected]
  └─┬ [email protected]
    └─┬ [email protected]
      └── [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants