Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hotkeys on readthedocs #141

Open
bollwyvl opened this issue Oct 24, 2024 · 2 comments
Open

Disable hotkeys on readthedocs #141

bollwyvl opened this issue Oct 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@bollwyvl
Copy link
Contributor

Description

The injected ReadTheDocs hotkeys make the d button unresponsive.

Reproduce

  1. Go to jupyterlite-pyodide-kernel.readthedocs.io
  2. try to type d in a cell
  3. do not see d

Expected behavior

Can press d and see a d.

Ideas

For now, we can only globally disable the hotkeys setting in the ReadTheDocs settings. I think the other addons are mostly fine. I don't appear to have access, but might be using the wrong account or something.

Ideally, we'd find a way to inject some DOM (likely in jupyterlite-core) that would disable this behavior.

Context

  • JupyterLite version: all
  • Operating System and version: any
  • Browser and version: any
Browser Output
Paste the output from your browser Javascript console here.
@bollwyvl bollwyvl added the bug Something isn't working label Oct 24, 2024
@jtpio
Copy link
Member

jtpio commented Oct 24, 2024

Thanks @bollwyvl.

You should now have access to the project on ReadTheDocs: https://readthedocs.org/projects/jupyterlite-pyodide-kernel/

Related issue on the JupyterLite repo: jupyterlite/jupyterlite#1499

@bollwyvl
Copy link
Contributor Author

Cool, disabled hotkeys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants