Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedInformerFactory missing a Shutdown method #22

Open
trozet opened this issue May 22, 2024 · 2 comments
Open

SharedInformerFactory missing a Shutdown method #22

trozet opened this issue May 22, 2024 · 2 comments

Comments

@trozet
Copy link

trozet commented May 22, 2024

The Shutdown method is useful for waiting for the informer to be stopped when running unit tests:
kubernetes/code-generator@e4b7976

It is missing:
https://github.com/k8snetworkplumbingwg/multi-networkpolicy/blob/master/pkg/client/informers/externalversions/internalinterfaces/factory_interfaces.go#L34

I tried updating code-gen and regenerating, but it doesnt seem to work. Not sure why...

@jcaamano
Copy link

WE have a similar situation with the NAD factory

@tssurya
Copy link

tssurya commented Jun 19, 2024

yeah hit this with the NAD factory today (I wonder if there is another issue for NAD or if we should open one...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants