-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.7.10 Thermos: NoClassDefFoundError/ReflectionException #1340
Comments
Hey! First of all, you only use the BungeeControl version provided with the zip file of you chatcontrolred version (but you already now this). Clickable text won't work at all for versions prior MC 1.8 which is the cause of a part of your issues. As for the exceptions thrown in the console, it looks like these are caused by deprecated events. Some special characters may not work because you used windows while running your tests. Hopefully these ones shouldn't happen on a linux-based OS. I'll ask you to wait for Kangarko to have a look at your issue to see what can be done here. However, if you don't mind, in the meantime, can you please try to reproduce as much issues as you can find and provide us the error.log file? This should help Kangarko finding the cause of these issues, and potentially fixing most of them as fast as he can 😉 |
I am aware, just letting you know about issues that may occur with the plugin when used on older versions. The tour is several pages, so adding a "/chc tour 2" to access the second page and so on in the event someone uses a pre-1.8 version would be helpful. All special character errors are from both Windows 10, and from Ubuntu 20.04, unfortunately, and show in the logs as a YAML parse error. This appears to be limited to 1.7.10/Thermos (of what I have tested with), as it works fine on Paper 1.17.1 and 1.16.5 without error. The Debug zip contains the Error log, but I have the relevant sections of both it and my main server log below; Error.log from ChatControl:
On Join, from Server log:
Constant spam (every tick) while joined from Server log;
On chat attempt from Server log;
On debug run from Server log;
And lastly, on Quit from Server log;
|
I have solved most of these errors, keep in mind that Particles are not supported on your installation. Closing, if the next version causes anything else let me know below please! |
To lead with; Yes it did fix most of the issues (and all the ones I had brought up), so thank you very much for looking into fixing such an old and duct taped version at all! Secondly, it mostly works, but two issues remain. These are not directly related to the original issue, so I can make a new issue if needed. Issue one; Chat is correct on all other servers, issue is isolated to Thermos, however I CAN see join/quit/switch messages from bungee control; Specific versions in use; Proxy; HexagonMC v277; MySQL: True NOTE: The MySQL library that comes with Thermos 58 may or may not work. It didn't for me, as it failed to log in to my database. I had to "borrow" a slightly updated version from Magma 1.12.2. I realize how bad that sounds from a support standpoint, but it worked for DiscordSRV, so... I have limited the channel down to the bare minimum for testing;
I see no errors about this in ChatControl/BungeeControl related to these incoming chats, BUT; Issue two;
Any hope this can be suppressed if otherwise working as intended? |
I can have a look later this week, likely the error can be mitigated but I am afraid I won't be able to help with the chat not being properly distributed on Bungee |
I would appreciate the error suppression but wouldn't the thermos server getting chat from BungeeControl on server switch imply that it is indeed getting something distributed to it? I checked the channel logs via /chc log all channel:global, and I can see the logged chat from both servers as expected, so the SQL connection seems fine, but when I run /ch list I get conflicting answers; https://i.imgur.com/z97fqX8.png and I get an error;
I enabled the chat forwarder for BungeeControl for the Thermos server and disabled bungee support in ChatControl on Thermos and I'm seeing chat come through both ways now; https://i.imgur.com/VSjK4Xt.png but obviously it isn't formatted. I understand that you do not have control over if Bungee sends packets or not, or if Spigot/Thermos receive them and direct them properly, and I have verified via Chatcontrol's Debug/Bungee option in settings that ChatControl on the Thermos server is not "seeing" the messages come through like the 1.17.1 server is... but I am getting SOME packets, both from other servers ChatControl (or raw spigot/bungee chat events), and from BungeeControl... just not in a way that ChatControl on Thermos can interpret? Is there a way I can help narrow down exactly where it is failing? I could pack up a test environment configured the same way as my network quickly enough, and Hexacord/Crucible (newest Thermos fork) still get updates. They have an issue for a different plugin that describes a potential fix/workaround for a stack trace similar to the one above, but I do not know enough about java/plugin development to know what it really means for you. This is the link to said issue on their end; |
Actually, follow up; If this is not fixable, can this setting for BungeeControl;
be changed to be a "to" and "from" field like so?
If I enable chat forwarding for the server, I get unformatted chat in on thermos as expected, but I also get unformatted chat broadcasted to EVERY server from thermos. I already get formatted messages from my thermos server to others, so I only want other server's messages sent to the Thermos server, not both ways. I can then try to cancel the chat events that start with "<" on thermos and just do an "[Other][Nick pulled from PAPI] Message" or something, so at least chat is only abnormal on one server. I only use one channel anyway, so this workaround would be enough in the absence of full support. |
Sorry for the delay, Thermos is not on our priority list but I will be having a look in 1-2 days. |
In the next version, I managed to patch all of the errors on the latest Thermos fork: https://i.imgur.com/DsB3Q6t.png Sure, we can do that. I have added the option of To_Servers and From_Servers to the next version for BungeeControl Red. |
Minecraft Version: 1.7.10 Thermos Forge 1614 Build 58
MySQL: false
BungeeCord: false
Debug zip: https://ufile.io/a2dlsu0z
Apologies, but GitHub wouldn't let me upload it directly.
Testing;
Versions 10.4.5 and older work correctly.
Versions 10.4.6 - 10.4.9, ChatControl will no longer launch with Thermos.
Versions 10.5.0 - 10.6.4, ChatControl will launch, but upon player join or any other interaction will spam exceptions in log attempting to pass events. (see Debug file)
Error is replicatable on Thermos 1.7.10 Forge 1614 Build 58 server with only Vault and ChatControl (no mods, plugins, SQL, or Bungee), using a 1.7.10 Forge 1614 client with no mods via MultiMC.
My account was OP for testing, attempting to use only the Global channel for formatting at this time.
I would simply use 10.4.5, but the hope is to be able to sync this server into my Bungee (HexagonMC) proxy. I was able to get SQL working with an updated MySQL library (and DiscordSRV with their Thermos library workaround), but joining the server with 10.4.5 spams BungeeControl 3.6.4 with "Unknown action named: PLAYERS_SYNC" and won't pass chat, even with BungeeChatAPI. This is expected due to the version difference, but it forces me to need an updated version.
Additional notes;
Clicking in chat does not work in 1.7.10, so you are unable to progress the tour. This is bypassable if you either know the commands or do it from console.
There are many special characters in newer files (send/receive, localization, etc) that 1.7.10 will not parse. This wouldn't be an issue if attempting to parse them did not disable ChatControl entirely on a modpack that takes >5min to load. Deleting them solves the issue, but requires a few restarts.
I am aware that Thermos is possibly the most painful thing I could possibly be trying to tie into my network, and that supporting it is an annoyance, but any chance this could be looked at? There is no chance the pack I am trying to tie in (GTNH) will ever be moved from 1.7.10 to anything newer, and I have all functions except chat working as expected.
The text was updated successfully, but these errors were encountered: