Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Add retries #72

Open
dimpar opened this issue Aug 18, 2020 · 0 comments
Open

Add retries #72

dimpar opened this issue Aug 18, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dimpar
Copy link
Contributor

dimpar commented Aug 18, 2020

This issue came up during the e2e report generation while retrieving redemption cost:

If we're moving quickly through the deposit flow, it's possible that we will request redemption when one Infura node has minted the TBTC, but the other Infura node has not seen this yet. In this case, the TDT has not yet been transferred to the vending machine, so we call getRedemptionTbtcRequirement instead of getOwnerRedemptionTbtcRequirement. But the actual call goes to a node that has seen the minting occur, so the TDT is in the vending machine, causing the revert.

Action:
replace every call in tbtc.js with some sort of EthereumHelpers.callSafely that handles retries transparently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants