Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN preparations #95

Open
7 tasks done
keller-mark opened this issue Jun 22, 2024 · 7 comments
Open
7 tasks done

CRAN preparations #95

keller-mark opened this issue Jun 22, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@keller-mark
Copy link
Owner

keller-mark commented Jun 22, 2024

Resources:

Things to do/check

  • R CMD check --as-cran
  • Please ensure that R CMD check --as-cran has been run on the tarball to be uploaded before submission
  • Add DOI to Zarr publication(s) in package Description
  • As a general rule, neither data nor documentation should exceed 5MB (see dog.ome.zarr is 6MB and .* files through lots of check notes. #87 )
  • If running a package uses multiple threads/cores it must never use more than two simultaneously (may need to modify recent tests added in Read/write in parallel #91 )
  • Packages which use Internet resources should fail gracefully with an informative message if the resource is not available or has changed (and not give a check warning nor error). (may require changes in HttpStore)
  • Update GH Actions to run on Ubuntu, Mac, and Windows using an os strategy matrix
@keller-mark keller-mark added the enhancement New feature or request label Jun 22, 2024
dblodgett-usgs added a commit to dblodgett-usgs/pizzarr that referenced this issue Jun 30, 2024
@dblodgett-usgs
Copy link
Collaborator

Working on a bit of no internet grace. Probably some more to do yet.

@dblodgett-usgs
Copy link
Collaborator

With #93, we are pretty close to ready to go. I want to do a bit more testing without internet and we'll need to reduce the size of the demo data. There are two ways to do that -- either make it a download or reduce its size. Will comment on that issue about that.

@dblodgett-usgs
Copy link
Collaborator

With what I just pushed, I think we should call the http error issues resolved. There is now only one NOTE:

❯ checking installed package size ... NOTE
    installed size is  7.5Mb
    sub-directories of 1Mb or more:
      extdata   6.3Mb

I'll kick off a few more checks here and see if anything surfaces.

@dblodgett-usgs
Copy link
Collaborator

Looks like a few things are picked up by the cran winbuilder.

(note that I changed the description temporarily so it had me as maintainer so I could get the emails about the test)

https://win-builder.r-project.org/7zmyrXTli9Cp/00check.log

Nothing crazy in there.

Possibly misspelled words in DESCRIPTION:
  Zarr (3:19, 20:31)

Found the following (possibly) invalid URLs:
  URL: https://cran.r-project.org/web/packages/roxygen2/vignettes/rd-formatting.html
    From: README.md
    Status: 200
    Message: OK
    CRAN URL not in canonical form
  The canonical URL of the CRAN page for a package is 
    https://CRAN.R-project.org/package=pkgname

The Title field should be in title case. Current version is:
'Slice into Zarr arrays in R'
In title case that is:
'Slice into Zarr Arrays in R'

Found the following \keyword or \concept entries
which likely give several index terms:
  File 'ZarrArray.Rd':
    \keyword{(default),}
    \keyword{False,}
    \keyword{Object,}
    \keyword{String,}
    \keyword{True,}
    \keyword{provided,}
    \keyword{stored,}
    \keyword{value,}

* checking HTML version of manual ... [12s] NOTE
Found the following HTML validation problems:
ZarrArray.html:203:9 (ZarrArray.Rd:163): Warning: <a> illegal characters found in URI
ZarrArray.html:206:9 (ZarrArray.Rd:164): Warning: <a> illegal characters found in URI

@dblodgett-usgs
Copy link
Collaborator

image

@dblodgett-usgs
Copy link
Collaborator

Two notes from the winbuilder still.

New submission

Possibly misspelled words in DESCRIPTION:
  Zarr (3:19, 12:31)

Found the following (possibly) invalid URLs:
  URL: https://cran.r-project.org/web/packages/roxygen2/vignettes/rd-formatting.html
    From: README.md
    Status: 200
    Message: OK
    CRAN URL not in canonical form
  URL: https://github.com/traversc/qs (moved to https://github.com/qsbase/qs)
    From: README.md
    Status: 301
    Message: Moved Permanently
  URL: https://numcodecs.readthedocs.io/en/stable/vlen.html#vlenutf8
    From: README.md
    Status: 404
    Message: Not Found
The canonical URL of the CRAN page for a package is 
  https://CRAN.R-project.org/package=pkgname
For content that is 'Moved Permanently', please change http to https,
add trailing slashes, or replace the old by the new URL.

The Title field should be in title case. Current version is:
  'Slice into Zarr arrays in R'
In title case that is:
  'Slice into Zarr Arrays in R'

Found the following \keyword or \concept entries
which likely give several index terms:
  File 'ZarrArray.Rd':
    \keyword{(default),}
    \keyword{False,}
    \keyword{Object,}
    \keyword{String,}
    \keyword{True,}
    \keyword{provided,}
    \keyword{stored,}
    \keyword{value,}
    ```
    
    ```
    * checking HTML version of manual ... [13s] NOTE
Found the following HTML validation problems:
ZarrArray.html:203:9 (ZarrArray.Rd:185): Warning: <a> illegal characters found in URI
ZarrArray.html:206:9 (ZarrArray.Rd:186): Warning: <a> illegal characters found in URI

@dblodgett-usgs
Copy link
Collaborator

With what I just pushed to #124 -- I only see two notes.

One is related to urls with illegal "[" characters in them -- I don't see how we can change them without just removing documentation for those methods.

The other is related to the word "Zarr" not being recognized.

I think we are probably basically ready to submit to CRAN but a high level review of introductory documentation and caveats about how the package is new / in development would be good still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants