Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Not Working on Long Pages #87

Open
handsfreemc opened this issue Aug 3, 2016 · 4 comments
Open

Not Working on Long Pages #87

handsfreemc opened this issue Aug 3, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@handsfreemc
Copy link

Pick a color from web page stalls out

I've refreshed, closed browser, and reinstalled the extension. Still, the circling ball will not stop spinning, so the cursor can never select a color. It usually takes about a second. For now, it's spinning several minutes with no stabilization.

@handsfreemc
Copy link
Author

Just noticed it's an isolated problem happening on this page: [https://designschool.canva.com/blog/100-color-combinations/]
Tested on yahoo.com main and it's working properly.

@kepi kepi added impact: low type: bug Bug reports labels Aug 3, 2016
@kepi kepi added this to the v0.4.2 milestone Aug 3, 2016
@kepi kepi self-assigned this Aug 3, 2016
@kepi
Copy link
Owner

kepi commented Aug 3, 2016

Thanks for report, I can reproduce it. I'm marking it as low because it is only problem on specific page. Anyway I should get to it soon after new version release (which is almost finished).

@kepi kepi changed the title [Pick from web tab] Pick a color feature is not allowing circling ball to rest long enough to choose a color Not Working on designschool.canva.com Aug 4, 2016
kepi added a commit that referenced this issue Aug 14, 2016
There are limits to size of canvas elements which I didn't checked
before.

This quick hack enables at least partial functionality (for start of
page) on really long pages (see #87).
@kepi
Copy link
Owner

kepi commented Aug 14, 2016

Ok, this problem is more serious than I thought. Eye Dropper is not working correctly on larger pages (longer than 32747 pixels). Its big change to fix this properly. I need to rewrite most of color picking logic.

Anyway, I made quick hack now which fix this at least partially. You can use Eye Dropper now on long pages but it will work only at start of a page (before you scroll more than those 32k pixels). I think is sufficient for most use cases. Of course, I'll fix this properly, but it will take some time.

@kepi kepi changed the title Not Working on designschool.canva.com Not Working on Long Pages Aug 14, 2016
@handsfreemc
Copy link
Author

@kepi Great to know, thanks for the update.

@kepi kepi modified the milestones: v0.5.0, v0.5.x bugfixes Nov 26, 2017
@kepi kepi modified the milestones: v0.5.x bugfixes, v0.6.x May 28, 2022
@kepi kepi modified the milestones: v0.6.x, maybe Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants