Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display letter summary in search results #101

Closed
svandaalen opened this issue Apr 4, 2024 · 5 comments
Closed

Display letter summary in search results #101

svandaalen opened this issue Apr 4, 2024 · 5 comments
Assignees
Labels

Comments

@svandaalen
Copy link
Collaborator

Request from Nina:

Ik zou daaronder ook graag hebben dat de summary in Engels zichtbaar is, dan kunnen mensen eventueel meteen zien of deze brief nuttig is voor hen (dat stond ook in onze wensenlijst, maar dat hebben we bij vorig overleg niet meer besproken, zie https://edition-humboldt.de/briefe/index.xql?l=en waar ze begin van de brief geven, maar lijkt me ideaal voor de samenvatting).

@svandaalen
Copy link
Collaborator Author

This also requires some work on the side of Broccoli. In any way, shape, or form the summaries have to be added to the Elastic index so that TAV can display the summaries in the search hits. Are we going to add them as type text? Where does Broccoli get the summaries from? The summaries sit in body.metadata.summary of a tf:File annotation.

@hayco
Copy link

hayco commented Apr 30, 2024

Next step forward is to add body.metadata.summary to the index. This will cause ES to index the summary field and makes it 'findable'. It will also add summary to search results passed by 🥦.

@hayco
Copy link

hayco commented Apr 30, 2024

The Suriano index used in TAV now contains a summary field.

This leaves TAV to show the summary field for now.

@hayco
Copy link

hayco commented May 1, 2024

Highlighting search terms in index fields requires some changes in 🥦 -> knaw-huc/broccoli#50

@svandaalen
Copy link
Collaborator Author

This functionality has been added in TAV in f6b6453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants