vSphere credentials Secret creation fails if VSPHERE_SERVER contains a trailing slash

[xmudrii]

What happened?

If VSPHERE_SERVER environment variable contains a trailing slash, creating vSphere credentials Secret fails because / is not an allowed character in a key name.

The key names in the vSphere credentials Secret are using the pattern of {{ .VSPHERE_SERVER }}.{{ .username}} and {{ .VSPHERE_SERVER }}.{{ .password}}. If VSPHERE_SERVER has a trailing slash, the generated key name would be <server>/.username which is not allowed by Kubernetes.

kubeone/pkg/credentials/secret.go

Lines 213 to 218 in e43259a

	vcenterPrefix := strings.ReplaceAll(credentials[VSphereAddressMC], "https://", "")
	// Save credentials in Secret and configure vSphere cloud controller
	// manager to read it, in replace of storing those in /etc/kubernates/cloud-config
	// see more: https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/k8s-secret.html
	vscreds[fmt.Sprintf("%s.username", vcenterPrefix)] = credentials[VSphereUsernameMC]
	vscreds[fmt.Sprintf("%s.password", vcenterPrefix)] = credentials[VSpherePassword]

Expected behavior

There are two possible options:

• Reject VSPHERE_SERVER values that have a trailing slash
• Drop a trailing slash in the linked function

How to reproduce the issue?

• Set VSPHERE_SERVER environment variable to a value that contains a trailing slash
• Try to provision or upgrade a cluster

What cloud provider are you running on?

vSphere

Additional information

This code might have another bug. We drop https:// prefix, but not http://, which might be a valid prefix too (we should verify that).