CSI Differential Snapshot for Block Volumes

[phuongatemc]

Enhancement Description

• One-line enhancement description (can be used as a release note): Add Differential Snapshot to CSI to provide a common method get differential snapshots of two arbitrary CSI VolumeSnapshots for PersistentVolumes that are backed by Block volumes in the backend storage.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3314-csi-changed-block-tracking/README.md
  CSI spec PR: Added the SnapshotMetadata service. container-storage-interface/spec#551
• Discussion Link: https://hackmd.io/VN_TBl3NSLaeiD8BLeeCfw?view
• Primary contact (assignee): @ihcsim @Braganza @PrasadG193
• Responsible SIGs: SIG-Storage
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.32
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-3314: CSI Changed Block Tracking #4082, KEP-3314: Update alpha target and latest-milestone for 1.32 #4909
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[xing-yang]

/sig storage

[xing-yang]

/wg data-protection

[xing-yang]

/milestone v1.25

[jasonbraganza]

Hello @phuongatemc 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable
• KEP has a updated detailed test plan section filled out
• KEP has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

• Have a KEP with all the above checkpoints included and a completed PRR, merged in kubernetes/enhancements repo

Open KEP PR #3367

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[jasonbraganza]

Hello @phuongatemc, @ihcsim 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

Please plan to get the above done before enhancements freeze on Thursday, June 16, 2022 at 18:00 PM PT.

For note, the current status of the enhancement is atat-risk. Thank you!

[phuongatemc]

@jasonbraganza I have updated the issue description with the PR #3367
This is still an work in progress so we don't have the code ready yet but here is our repository https://github.com/phuongatemc/diffsnapcontroller/

[jasonbraganza]

Thank you so much for the updates, @phuongatemc 🙂

Could you please, make the following updates in you open PR #3367

1. Update the status from provisional to implementable in the kep.yaml file.
2. Please update the test plan section, to add the test information in the requested format, as described in the template

Please plan to have the PR merged, before the updated enhancements freeze date on Thursday, June 23, 2022.

[ihcsim]

@jasonbraganza thanks - we added the test plan section yesterday. I thought the KEP must be approved before we can update it to implementable.

[jasonbraganza]

Hello @ihcsim. Just checking in, as we are four days away from the enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

I thought the KEP must be approved before we can update it to implementable.

For a KEP to be tracked in release cycle, it should be marked as implementable.

Kindly plan to have the PR merged by the freeze date.

Please note: the current status of the enhancement is at-risk.
Thank you.

[Priyankasaggu11929]

Hello, 1.25 Enhancements Lead here 👋. With Enhancements Freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for enhancements freeze is:

• KEP file using the latest template has been merged into the k/enhancements repo, with up to date latest milestone and stage
• KEP status is marked as implementable
• KEP has an updated detailed test plan section filled out
• KEP has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

[xing-yang]

/milestone v1.26

[PrasadG193]

Hey @tjons, since the KEP is already merged, are we expected to raise a PR for this change?

[tjons]

Hi @PrasadG193 - yes, the KEP status is required to be implementable for the latest-milestone of the current release.

[PrasadG193]

@tjons PTAL at #4909

[tjons]

@PrasadG193 Once that merges, the requirements will be met! Please reach out to reviewers to make sure that the changes merge before enhancements freeze tomorrow evening.

[tjons]

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

[rdalbuquerque]

Hello @PrasadG193 👋, 1.32 Docs Shadow here.
Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[PrasadG193]

@rdalbuquerque I've created a draft PR at - kubernetes/website#48456, please let me know if anything else is needed. Thank you!

[wrkode]

👋 Hi there, William here from v1.32 Comms
We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[PrasadG193]

Hey @wrkode, I've already opened a placeholder PR kubernetes/website#48456, let me know if anything else is needed.

[wrkode]

Hi @PrasadG193, this is enough for now, thanks a million

[tjons]

Hello @PrasadG193 👋, Enhancements team here.

Are there any code changes planned for this KEP in 1.32? If so, please let me know and add them to the issue description. I will mark this KEP as at risk for code freeze until I hear from you.

[PrasadG193]

Hey @tjons ,
We would like to address the following issues before the release -

• Add E2E tests kubernetes-csi/external-snapshot-metadata#13
• CSI driver developer support  kubernetes-csi/external-snapshot-metadata#17
• Add example of csi hostpath driver kubernetes-csi/external-snapshot-metadata#62

[tjons]

Hello @PrasadG193 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.32 milestone. I am basing this off of the three issues still open without PRs that you linked above.

If you still wish to progress this enhancement in 1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

[dipesh-rawat]

Hello @PrasadG193 👋, 1.33 Enhancements Lead here.

If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.33 using /milestone v1.33.
Thanks!

/remove-label lead-opted-in

[PrasadG193]

/lead-opted-in

[PrasadG193]

@dipesh-rawat Yes, we would like to continue working on this enhancement. Do we need to ask the sig-storage lead to add the labels? Also, this feature is out-of-tree to K8s and can be released independently from the K8s release cycle.