Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rootless: support --container-runtime=docker #17322

Closed
AkihiroSuda opened this issue Sep 29, 2023 · 2 comments · Fixed by #17520
Closed

rootless: support --container-runtime=docker #17322

AkihiroSuda opened this issue Sep 29, 2023 · 2 comments · Fixed by #17520
Assignees
@AkihiroSuda
Labels
co/runtime/docker Issues specific to a docker runtime kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@AkihiroSuda
Copy link
Member

Currently --rootless requires --container-runtime to be containerd or cri-o, due to:

After fixing this issue, --container-runtime can be set to docker too.

PR for Docker:

WIP PR for minikube:
@afbjorklund afbjorklund added co/runtime/docker Issues specific to a docker runtime kind/feature Categorizes issue or PR as related to a new feature. labels Sep 29, 2023
@medyagh
Copy link
Member

medyagh commented Oct 5, 2023

nice once that PR is merged and released in moby project I would be happy to see it in minikube too

@medyagh medyagh added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 5, 2023
@AkihiroSuda AkihiroSuda mentioned this issue Oct 29, 2023
Merged
@AkihiroSuda
Copy link
Member Author

PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AkihiroSuda AkihiroSuda

Labels
co/runtime/docker Issues specific to a docker runtime kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rootless: support --container-runtime=docker AkihiroSuda/minikube
3 participants
@medyagh @AkihiroSuda @afbjorklund