Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Validation webhook for serviceexport #358

Open
2 tasks done
mridulgain opened this issue Apr 1, 2024 · 5 comments · May be fixed by #379
Open
2 tasks done

Feature: Validation webhook for serviceexport #358

mridulgain opened this issue Apr 1, 2024 · 5 comments · May be fixed by #379
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mridulgain
Copy link
Contributor

🔖 Feature description

Validate serviceexport objects during admission.

🎤 Pitch

Exporting a service by creating a serviceexport object only makes sense when it's created withing the application namespace of the specified slice. Currently user may create a serviceexport with a slice name even if the slice object is not present on that cluster or in case it's present but doesn't even has any application namespace onboarded.

✌️ Solution

Implement a validation webhook that checks,

  1. The specified slice is present on the cluster
  2. The namespace in which the serviceexport is being created, is present in the "onboarded application namespace" array.

🔄️ Alternative

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@kon3m
Copy link
Contributor

kon3m commented Apr 4, 2024

would like to work on this ,can you please assign me this issue? @mridulgain

@narmidm
Copy link
Member

narmidm commented Apr 15, 2024

sure @kon3m. I have assigned this issue to you. Let us know @kon3m, if you need any help with this issue or you can connect directly with @mridulgain for any discussion on slack channel.

@kon3m
Copy link
Contributor

kon3m commented Apr 24, 2024

@narmidm @mridulgain i cannot work on this issue until this PR gets merged. Will work on another issue till then.

@narmidm
Copy link
Member

narmidm commented Apr 24, 2024

Certainly, @kon3m, I will attempt to close the other pull request soon. After that, you can return to this issue.

@kon3m kon3m linked a pull request Apr 29, 2024 that will close this issue
11 tasks
@chetak123
Copy link

Hey @kon3m are you currently working on this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

8 participants