Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(row|column)_style_hermite_normal_form do not return unique form #4

Open
lan496 opened this issue Feb 12, 2019 · 1 comment
Open

(row|column)_style_hermite_normal_form do not return unique form #4

lan496 opened this issue Feb 12, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@lan496
Copy link
Owner

lan496 commented Feb 12, 2019

let H = AR, H is HNF of A, then H=(h_{ij}) should satisfy the following conditions:
(1) h_{ij} = 0 (for i < j)
(2) h_{ii} >= 0
(3) 0 <= h_{ij} < h_{ii} (for i > j s.t. h_{ii} > 0)
(4) h_{ij} = 0 (for i > j s.t. h_{ii} = 0)

But, (3) and (4) are broken in my current implementation......

@lan496 lan496 added the bug Something isn't working label Feb 12, 2019
@lan496
Copy link
Owner Author

lan496 commented Feb 13, 2019

In the first place, condition (4) is wrong.
I need to learn about SNF and HNF for singular-matrix

@lan496 lan496 added enhancement New feature or request and removed bug Something isn't working labels May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant