Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable delete button when utter has a single balloon #150

Open
4 tasks done
rodmaia opened this issue Feb 23, 2021 · 6 comments · May be fixed by #163
Open
4 tasks done

Disable delete button when utter has a single balloon #150

rodmaia opened this issue Feb 23, 2021 · 6 comments · May be fixed by #163
Assignees
@Miguel-Alves
Labels
enhancement New feature or request frontend

Comments

@rodmaia
Copy link
Collaborator

rodmaia commented Feb 23, 2021 •
edited by Miguel-Alves
Loading

When an utter has a single text balloon, the delete button of that balloon should be disabled as you cannot leave an utter with zero balloons. The delete button should be reenabled once you add more balloons.

Tasks

  • Steps to complete this task
  • Steps to complete this task

Acceptance criteria

  • Delete button is disabled when there is a single balloon
  • Delete button is enabled when there are two or more balloons
@rodmaia rodmaia added enhancement New feature or request frontend labels Feb 23, 2021
@Miguel-Alves Miguel-Alves mentioned this issue Feb 25, 2021
Open
4 tasks
@Miguel-Alves
Copy link
Collaborator

Reviewing this issue based on #153;

@Miguel-Alves Miguel-Alves self-assigned this Feb 25, 2021
@Miguel-Alves
Copy link
Collaborator

Miguel-Alves commented Mar 2, 2021 •
edited
Loading

This issue is very similar to #151 . And, as it happened to it's "sister", happens here either.
This work is kind of redundant as already exists a validation that does not allow the user to delete the last content.
But, following the procedures of #153 , this issue is maintained;

@Miguel-Alves Miguel-Alves linked a pull request Mar 2, 2021 that will close this issue
Open
@Miguel-Alves
Copy link
Collaborator

Solved this issue adding another validation to the button when editing utters, as described in #163 ;
Then, this issue was moved to "Awaiting Review"

@rodmaia
Copy link
Collaborator Author

rodmaia commented Mar 2, 2021

This work is kind of redundant as already exists a validation that does not allow the user to delete the last content.

See #151 (comment)

@Miguel-Alves
Copy link
Collaborator

Checked it and now I understand these needs and procedures. Anyway, I added the validation that solves this issue and a PR solving it is open

@rodmaia
Copy link
Collaborator Author

rodmaia commented May 19, 2021

I tested it! Looks good on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Miguel-Alves Miguel-Alves

Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#150 disable delete button on single ballon lappis-unb/BotFlow
2 participants
@rodmaia @Miguel-Alves