Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some errors could not be fatal #28

Open
leonbloy opened this issue Jan 7, 2015 · 1 comment
Open

Some errors could not be fatal #28

leonbloy opened this issue Jan 7, 2015 · 1 comment

Comments

@leonbloy
Copy link
Owner

leonbloy commented Jan 7, 2015

From [email protected] on January 22, 2014 23:18:10

In particular, if an ancillary chunk has some internal problem (this does not include its outer structure: length - but could include crc), the reader should, optionally, omit them.

Original issue: http://code.google.com/p/pngj/issues/detail?id=28

@leonbloy
Copy link
Owner Author

As today, one can skip CRC checking by calling PngReader.setCrcCheckDisabled()

But the idea of that method was mainly to speed up a little the reading. It might be useful
to check the CRC but only emit a warning if fails. And to add more lenient strategies for
reading bad structures (eg, no END chunk, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant