Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpal Sink to librespot #145

Closed
sashahilton00 opened this issue Feb 12, 2018 · 6 comments
Closed

Add cpal Sink to librespot #145

sashahilton00 opened this issue Feb 12, 2018 · 6 comments

Comments

@sashahilton00
Copy link
Member

Currently, discussion to get Windows support is under way. Hopefully rust-mdns will be updated to work with Windows soon (#140), at which point, to ease running on Windows (and other systems), it would be good to implement a https://github.com/tomaka/cpal Sink for playback, which will remove the dependency on portaudio/pulseaudio, somewhat reducing the inconvenience of (cross) compiling for Windows.

@awiouy
Copy link
Collaborator

awiouy commented Feb 13, 2018

I have come across these today:

What do you think?

@sashahilton00
Copy link
Member Author

It looks to do a similar job to cpal, except that it's implemented by another library which has rust bindings, whilst cpal is pure rust. Is there a benefit to using libsound over cpal?

@mfeif
Copy link

mfeif commented Mar 22, 2018

One benefit is keeping Pulseaudio, which is the de-facto sound stack on all modern linux (I think).

@burnoutberni
Copy link

Is any work being done in this direction? A friend of mine just got one of these new Nokia "banana phones" and it runs KaiOS (formerly B2G/FirefoxOS), with all apps being "web apps". We're playing around with a couple of things now and an interesting side project might be to go ahead and try compiling librespot to WebAssembly. Not really sure where to start (Rust newbie here), but one of the main things would be to have WebAudio backend, which cpal seems to support.

@willstott101
Copy link
Contributor

Since #277 got merged I guess this can be closed now?

Taking this opportunity to mention that the README is now out of date.

@sashahilton00
Copy link
Member Author

Yup. Updated the readme. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants