Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS Note 8.1: Add Manager Can Increase Stake #495

Open
bingen opened this issue Oct 9, 2024 · 1 comment
Open

CS Note 8.1: Add Manager Can Increase Stake #495

bingen opened this issue Oct 9, 2024 · 1 comment
Assignees
Labels
ChainSecurity wontfix This will not be worked on

Comments

@bingen
Copy link
Collaborator

bingen commented Oct 9, 2024

The addManager is generally not trusted, as it can only improve the collateralization ratio of a trove. If the manager is set to address 0, anyone can add collateral to a trove.

However, increasing the collateral of a trove also increases its stake. In extreme scenarios where redistributions give more debt to active positions than collateral, an attacker could send collateral to another trove owner to increase their share in the bad redistributions.

Users who want to avoid this can set the addManager to the same address as the owner, which will disallow others from increasing their collateral.

@bingen bingen self-assigned this Oct 20, 2024
@bingen bingen added the wontfix This will not be worked on label Oct 20, 2024
@bingen
Copy link
Collaborator Author

bingen commented Oct 20, 2024

We’ll add this risk to the list of known issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChainSecurity wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant